Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid validation warning for "setupTestFrameworkScriptFile" #4994

Closed
SamyPesse opened this issue Dec 1, 2017 · 6 comments
Closed

Invalid validation warning for "setupTestFrameworkScriptFile" #4994

SamyPesse opened this issue Dec 1, 2017 · 6 comments

Comments

@SamyPesse
Copy link

Using jest 21.3.0-beta.11, I'm getting a warning:

● Validation Warning:

  Unknown option "setupTestFrameworkScriptFile" with value "<rootDir>/setup-tests.js" was found.
  This is probably a typing mistake. Fixing it will remove this message.

  Configuration Documentation:
  https://facebook.github.io/jest/docs/configuration.html

But this option doesn't seem invalid or deprecated (and it's still working in my tests).

@thymikee
Copy link
Collaborator

thymikee commented Dec 1, 2017

It was accidentally deleted from validation in #4976. Our CI confirms your warning (but who looks at CI output, when it's green?).
Would you like to bring it back? It's adding back this line:
https://github.com/facebook/jest/pull/4976/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L130 🙂

@SimenB
Copy link
Member

SimenB commented Dec 2, 2017

@thymikee what's going on here? Seeing as #4995 got closed

@thymikee
Copy link
Collaborator

thymikee commented Dec 2, 2017

We only need one hook in our package.json. The issue is about validation. Jest-validate needs a reference for valid config. The issue is that scriptFile was accidentally removed from the valid config example, hence the warning

@cpojer
Copy link
Member

cpojer commented Dec 4, 2017

cc @mjesun can you fix this today pls? :)

@cpojer cpojer closed this as completed Dec 15, 2017
@cpojer
Copy link
Member

cpojer commented Dec 15, 2017

Fixed.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants