Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving away from Node's default IPC mechanism #4942

Closed
mjesun opened this issue Nov 23, 2017 · 5 comments
Closed

Investigate moving away from Node's default IPC mechanism #4942

mjesun opened this issue Nov 23, 2017 · 5 comments
Assignees

Comments

@mjesun
Copy link
Contributor

mjesun commented Nov 23, 2017

Currently, jest-worker uses internal Node's IPC mechanism; which in turn uses JSON serialization to transmit objects.

We should investigate if we could gain some speed + versatility if we switched to use v8.serialize / v8.deserialize V8's APIs, which are exposed through the v8 module. These methods allow to serialize Date and RegExp objects, and they also make possible to serialize circular references.

In addition to that, we should use some sort of transmission mechanism to pass native buffers between processes; xpipe seems to be a good solution for that.

@mjesun mjesun assigned mjesun and BYK Nov 23, 2017
@mjesun
Copy link
Contributor Author

mjesun commented Nov 23, 2017

Assigning it to @BYK who is interested in experimenting with this.

Some code pointers:

@SimenB
Copy link
Member

SimenB commented May 27, 2018

This has been investigated and abandoned, right?

@SimenB
Copy link
Member

SimenB commented May 27, 2018

Yup, #5613. Feel free to reopen if you still wanna track it

@SimenB SimenB closed this as completed May 27, 2018
@mjesun
Copy link
Contributor Author

mjesun commented May 27, 2018

I'm not sure we ever investigated this. @rafeca, would you be interested in taking it?

Edit: yes, we did investigate for the v8.serialize part, and it was slower than JSON.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants