Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated contribution guidelines for website / documentation #4911

Closed
d4nyll opened this issue Nov 18, 2017 · 4 comments
Closed

Outdated contribution guidelines for website / documentation #4911

d4nyll opened this issue Nov 18, 2017 · 4 comments
Assignees

Comments

@d4nyll
Copy link
Contributor

d4nyll commented Nov 18, 2017

Currently, the contributions guidelines for updating website / documentation has a step for running tests on the website.

cd website       # Only needed if you are not already in the website directory
yarn
yarn test

But having just pulled in the latest version of Jest (with hash 3d84d75374d23b035cc87cba14afaa7b761273b7), there are no NPM scripts with the name test

$ yarn test
yarn run v1.3.2
warning package.json: No license field
error Command "test" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@SimenB
Copy link
Member

SimenB commented Nov 18, 2017

/cc @ericnakagawa

@gehrhorn
Copy link
Contributor

I'm trying to follow these instructions too. To add on, the npm start command works, but I get an error.

image

Is there a step missing to running a local copy related to translations?

@thymikee
Copy link
Collaborator

Works now, sorry about inconvenience!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants