Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make integration_tests pass for node releases and master #4062

Closed
AnnaMag opened this issue Jul 18, 2017 · 3 comments
Closed

make integration_tests pass for node releases and master #4062

AnnaMag opened this issue Jul 18, 2017 · 3 comments

Comments

@AnnaMag
Copy link

AnnaMag commented Jul 18, 2017

Do you want to request a feature or report a bug?
bug
What is the current behavior?
Two Jest integration tests do not pass for node official releases and current master:
integration_tests/__tests__/show_config.test.js and
integration_tests/__tests__/stack_trace_no_captureStackTrace.js.

If the current behavior is a bug, please provide the steps to reproduce and either a repl.it demo through https://repl.it/languages/jest or a minimal repository on GitHub that we can yarn install and yarn test.
set PATH to node
yarn (or yarn --ignore-engines for local build) and yarn test from within the Jest dir
What is the expected behavior?
Tests passing
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
Jest: master e9a6f71
node: master c3cb0ed (same happens for release branches, tested for 6+)
yarn: 0.27.5
macOS Sierra

What fixed the problem for me:

  • update snapshot for show_config.test.js
  • replace
    expect(stderr).toMatch(/\s+at\sJestAssertionError\s.*/);
    with the call
    expect(stderr).toMatch( /\s+at\s(?:.+?)\s\(__tests__\/runtime_error.test\.js/, );
    in stack_trace_no_captureStackTrace.js. RunJest does not
    seem to return at JestAssertionError string, afaiu (might be wrong :)).
@AnnaMag AnnaMag changed the title make integration_tests/__tests__/* pass for node releases/master make integration_tests pass for node releases and master Jul 18, 2017
@cpojer
Copy link
Member

cpojer commented Jul 18, 2017

Sorry about that. Those two should be fixed on master now ( 009c065 ). Mind confirming that this works properly?

@AnnaMag
Copy link
Author

AnnaMag commented Jul 18, 2017

@cpojer, confirmed 👍

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants