Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose FakeTimers.timers: [TimerID] #3949

Closed
nrako opened this issue Jun 30, 2017 · 7 comments
Closed

Expose FakeTimers.timers: [TimerID] #3949

nrako opened this issue Jun 30, 2017 · 7 comments

Comments

@nrako
Copy link

nrako commented Jun 30, 2017

Do you want to request a feature or report a bug?
feature

What is the current behavior?
FakeTimers doesn't expose _timers making hard to test if a timer id is present (not cleared).

What is the expected behavior?
I was looking for a way to test the non-existence of a "timeout id" after a clearTimeout but I believe that the "timers" ids are not exposed.

With sinon this would be done like this:

describe('when unmounted', () => {
    it('clears timeout', () => {
      const clock = sinon.useFakeTimers()
      const timeout = wrapper.instance().timeout
      expect(timeout).toBeDefined()
      wrapper.unmount()
      expect(clock.timers).to.not.include.keys(timeout.id)
    })
})

What would you think of exposing it?

@thymikee
Copy link
Collaborator

I believe this could be addressed with this PR: #5165. cc @SimenB

@SimenB
Copy link
Member

SimenB commented May 22, 2018

We still don't expose the underlying timers. we might want to expose the underlying clock though, not sure

@thymikee
Copy link
Collaborator

I think it wouldn't harm to return it. But it might be better idea to do it as a followup, when we're sure Lolex is here to stay.

@SimenB
Copy link
Member

SimenB commented May 22, 2018

We keep track of the timers today, so potentially, we could expose it: https://github.com/facebook/jest/blob/74892f0f6a0abd6a4e9d5a7053fdcd22e4f6d23c/packages/jest-util/src/fake_timers.js#L80

Keeping that API after a Lolex migration is simple

@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 26, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants