Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-identical-titles): support nested describes #790

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

idan-at
Copy link
Contributor

@idan-at idan-at commented Mar 10, 2021

In this case, because we pop the describe context on CallExpression:exit, but not insert one in the case of a template describe.each, we try to use describeTitles of undefined.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👍

@SimenB SimenB changed the title fix(no-identical-titles): missing describe context fix(no-identical-titles): support nested describes Mar 10, 2021
@SimenB SimenB merged commit ce26621 into jest-community:main Mar 10, 2021
github-actions bot pushed a commit that referenced this pull request Mar 10, 2021
## [24.2.1](v24.2.0...v24.2.1) (2021-03-10)

### Bug Fixes

* **no-identical-titles:** support nested describes ([#790](#790)) ([ce26621](ce26621))
@github-actions
Copy link

🎉 This PR is included in version 24.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants