Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default terminal for custom commands #1550

Open
MiroslavMikus opened this issue Oct 26, 2021 · 4 comments
Open

Change default terminal for custom commands #1550

MiroslavMikus opened this issue Oct 26, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MiroslavMikus
Copy link

MiroslavMikus commented Oct 26, 2021

Hey, I'm playing with custom commands and can't find docu/config to change the default terminal.

Describe the solution you'd like
I would like to change the default terminal path and parameters.

Describe alternatives you've considered
Right now we can kind of start powershell from CMD -_-
pwsh.exe -NoProfile -WindowStyle Hidden -command "& { gps > ps.txt}" - this does not work

I have found some documentation about subprocess in custom commands. Now, I'm running lazy-git in Powershell 7 and WindowsTerminal. It looks like whatever I choose to use subprocess or not I will end in CMD. Although I would expect it to be Powershell 7.

Thanks

@MiroslavMikus MiroslavMikus added the enhancement New feature or request label Oct 26, 2021
@alexn-s
Copy link

alexn-s commented Jun 16, 2022

+1

Are there any updates?
I would prefer to use powershell instead of cmd.exe

@mark2185 mark2185 added the good first issue Good for newcomers label Aug 8, 2022
@nullishamy
Copy link
Contributor

nullishamy commented Aug 15, 2022

After digging around a bit, it would seem we need to change the way the runners (commands/oscommands/*runner.go) operate, though it seems to be an issue with the lib that we use, pty. We should watch this?

@mark2185
Copy link
Collaborator

The link returns 404.

The thing is that these are currently hardcoded, e.g. bash for unix and cmd for windows (I'm guessing), we should make that configurable. Something like that is underway in #2096 .

@nullishamy
Copy link
Contributor

nullishamy commented Aug 15, 2022

Fixed the link. Does that affect the runners (assuming they are responsible for running custom commands)? I couldn't see a relation, though I'm not very familiar with the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants