Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans to support Set() defined by ES6? #2745

Closed
hanhui03 opened this issue Jan 31, 2019 · 5 comments
Closed

Are there any plans to support Set() defined by ES6? #2745

hanhui03 opened this issue Jan 31, 2019 · 5 comments
Labels
ES2015 Related to ES2015 features question Raised question

Comments

@hanhui03
Copy link

Are there any plans to support Set() defined by ES6?
And report a bug: Map() did not support forEach() method.

@LaszloLango
Copy link
Contributor

CC: @rerobika

@LaszloLango LaszloLango added question Raised question ES2015 Related to ES2015 features labels Jan 31, 2019
@hanhui03
Copy link
Author

And 'let' is a very necessary keyword, I recommend implementation ^_^

@akosthekiss
Copy link
Member

@acoinfo Issues should be focused. Right now, this issue seems to contain

  • a question ("Are there any plans to support Set() defined by ES6?"),
  • a bug report (?) ("Map() did not support forEach() method."), and
  • a feature request ("'let' is a very necessary keyword, I recommend implementation").

It's a lot easier to conduct discussions and reach conclusions if an issue is about a single topic. So, I'd suggest you to open separate issues for unrelated questions/feedbacks.

Moreover,

  • for bug reports, it is strongly preferred to include various details, like the version (git hash) the bug is reported against; the way the project is configured, built, and executed; the platform used to build and/or run the engine; a reproduction case (js file); and how the bug manifests itself; while
  • for feature requests, it is good practice to provide motivation and/or use cases that justify the proposal.

(Note: Actually, the bug report here is more like a feature request. The lack of support for part of the ES6/2015 standard is not a bug, as the project explicitly states that it implements only a subset of the ES6/2015 standard at the moment.)

@rerobika
Copy link
Member

rerobika commented Feb 1, 2019

@acoinfo Despite of having a separate issue for each question would be great let me give you a quick answer.

  • The Set builtin probably will be supported, but first we need to figure out how to combine the implementation with the Map builtin to reduce the code duplication.
  • It is not a bug, it's a feature request. Please open an issue for it.
  • let and const is more harder nut to crack. I'm working on it but it won't be published until their performance/memory usage produce similar results to what can be achieved via using vars.

@rerobika
Copy link
Member

@acoinfo #2841 has landed, so now you can use the Set builtin object, also the missing Map.prototype.foreach routine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ES2015 Related to ES2015 features question Raised question
Projects
None yet
Development

No branches or pull requests

4 participants