Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting the db-postgres and db-mariadb drivers. #1708

Closed
ioquatix opened this issue Aug 14, 2020 · 1 comment
Closed

Consider supporting the db-postgres and db-mariadb drivers. #1708

ioquatix opened this issue Aug 14, 2020 · 1 comment

Comments

@ioquatix
Copy link
Contributor

This issue is just to kick start a discussion around using db-postgres and db-mariadb as low level drivers.

I may try to do some of the heavy lifting as time permits, but in the first instance I just wanted to bring awareness of their existence.

The mysql2 gem does not expose enough hooks to be event driven.

The pg gem isn't far away from being event driven (see ged/ruby-pg#342) but I didn't want to wait.

I think we could probably create a gem db-sequel which exposes the right driver interfaces, rather than over-extending the implementation here (already has a ton of drivers). Another option might be to create sequel-driver-db or something like that.

Let me know what you think.

@jeremyevans
Copy link
Owner

As the contribution guide states, please start discussions like this on the sequel-talk Google Group. GitHub Issues should only be used for bug reports.

My gut feeling is it's probably best to first implement the adapter in a gem, and then depending on demand and ease of maintenance I could consider shipping the adapters with Sequel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants