Typecast $column to string when ordering

[apeisa]

Since $column parameter in Illuminate/Database/Query/Builder.php can take other types than strings, it makes sense to typecast this into a string.

This came up when using Filament Admin panel with Mongo, where orderBy doesn't work since the $column passed to orderBy isn't a string, but a Stringable object. There are probably other places also with a similar need and I will provide more PR:s as I find them.

[divine]

Hello,

Tests are failing, please check and let me know.

Thanks!

[apeisa]

Hi

Thanks for your comment. That one test failing in Mongo v4.2 cannot be related to this PR. For me, it looks like some kind of race condition since it is comparing timestamps and there is a one-second difference. So if possible, can you re-run the tests to see them pass?

[codecov-commenter]

Codecov Report

Merging #2419 (b86a8b8) into master (ad4422a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2419   +/-   ##
=========================================
  Coverage     87.62%   87.62%           
  Complexity      676      676           
=========================================
  Files            31       31           
  Lines          1551     1551           
=========================================
  Hits           1359     1359           
  Misses          192      192           

Impacted Files	Coverage Δ
src/Query/Builder.php	89.64% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4422a...b86a8b8. Read the comment docs.

[apeisa]

Hi @divine

I think the tests were re-run now and all passed.

[divine]

Hello,

I've rerun tests but not sure how this could be the problem with that package as they state no support for this package filamentphp/filament#1365?

Can you add a test to see what values pass this package and do indeed solve the problem?

Thanks!

[apeisa]

Hi

Thanks for the link. Filament works actually very well with Mongo, just few minor issues and this fixes the other one.

[apeisa]

I will add tests for this.

[apeisa]

Hi @divine! I created another PR (with better naming), which has tests for this also. You can find it from #2420