Add Model query whereDate support #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add tests please. |
Submitted test and add doc |
Smolevich
approved these changes
May 12, 2021
|
Hello, I think WhereDay , WhereYear do not work as expected. In the laravel documentation for instance for whereYear() the first parameter is the date and the second parameter is the year However in this instance the search operation is doing a standard search. You can see below a screenshot of the tests in this pull request |
|
Hello @kudjieRaymond , Instead of replying to merged pull requests create a new issue. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: Not supprt
whereDatequery.solutions:
According to the document:
So I hope to add
whereXXX, in order to compatible with laravel and facilitatedcat adminto use mongodb.