Check dates against DateTimeInterface instead of DateTime
#2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegamez
force-pushed
the
date-time-interface
branch
from
dfa1f8b to
0db1e61
Compare
jeromegamez
changed the title
DateTimeInterface instead of DateTime in the Query BuilderDateTimeInterface instead of DateTime
jeromegamez
force-pushed
the
date-time-interface
branch
from
0db1e61 to
dc32644
Compare
divine
approved these changes
Apr 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
============================================
+ Coverage 86.82% 86.88% +0.06%
Complexity 664 664
============================================
Files 33 33
Lines 1556 1556
============================================
+ Hits 1351 1352 +1
+ Misses 205 204 -1
Continue to review full report at Codecov.
|
|
Shall I address the StyleCI issues in a separate commit? |
Hello, No, we'll take care of it later. Thanks! |
Smolevich
approved these changes
Apr 30, 2021
|
Thank you for your contribution @jeromegamez ! |
|
🚀 Thank you both for accepting it! 🤗 |
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Check dates against `DateTimeInterface` instead of `DateTime`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greeting! 👋
I noticed that
where()queries in which I usedDateTimeImmutableobjects returned empty results.This change would allow the usage of
DateTimeImmutableorCarbonImmutablein addition toDateTime/Carbon🤞