-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using lib produces render error #9
Comments
Okay I figured out if my project already had a newest slate, this package newer got built well. Can you update to a newest slate-react? |
I'll look into this. |
To be honest, this repo unfortunately wasn't maintained well after its initially been published. I currently don't have the time to fix the compilation errors. It seems we need to update several dependencies and fix breaking changes. Help/PR's are welcomed! I'm really sorry but there seems no quick fix to me. If you could fix the bugs I'm able to publish the updated version to npm. |
Just wondering how feasible it is to make this work with the latest react, slatejs, and react-dnd? 🙁 |
Hey,
Repro steps scenario #1 (repo+example):
If you change the line in StoryEditor.js in example
import DragDropContainer from "../../dist/container"
to
import DragDropContainer from "slate-react-dnd-plugin"
the editor doesn't work.
Anytime I want to import the plugin to any of my project I have exact the same error. Somehow only the example works if you build the library one dir higher. But when it wants to use the actual npm package it is not working. Nor is the package working in any of my projects.
Am I doing something wrong or there is some configuration problem?
Repro steps scenario #2 (fresh react project):
Please try to create a simple react app anywhere, just use npm install slate-react-dnd-plugin --save and copy/paste App.js and StoryEditor.js. Change imports to 'slate-react-dnd-plugin' and you will see it doesn't work throwing render null errors. Here is the minified App.js that works in example folder (if lib is built one dir higher):
Here's the stack trace:
The text was updated successfully, but these errors were encountered: