Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example in Readme is Not working #8

Open
linonetwo opened this issue Apr 28, 2018 · 4 comments
Open

Example in Readme is Not working #8

linonetwo opened this issue Apr 28, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@linonetwo
Copy link

See https://stackblitz.com/edit/react-dhyzf3
@linonetwo linonetwo changed the title Not working. Example in Readme is Not working Apr 28, 2018
@linonetwo
Copy link
Author

Though ./example is working.

@gorillamoe
Copy link
Collaborator

Heya, thanks for pointing that out! I'm currently AFK and dunno when I've time to look into this, but you might be right. The readme might be outdated.

@jensneuse jensneuse added the good first issue Good for newcomers label Apr 28, 2018
@danielsetreus
Copy link

The reason seems to be that the package declares DnDProvider - but with an empty return. That triggers a error: DnDProvider(...): Nothing was returned from render.

In ./examples DnDProvider is not imported from the package but actually from the source file itself, in the ./dist directory. So I'm guessing this needs a updated package. When do you think that could happen?

@andreikho
Copy link

needs an update it's written still with the change() method which is deprecated since 0.43
change log here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gorillamoe @danielsetreus @linonetwo @jensneuse @andreikho