Skip to content

Step by step: first review creation

dbratell edited this page Nov 11, 2012 · 6 revisions

This is the work flow for creating a review.

Prerequisites:

  • Name of critic server and its repo (assumed to be critic.myserver.com:/var/git/projectrepo.git below).
  • Non-anonymous access to said critic server.
  • A branch with changes to be reviewed (assumed to be HEAD below).

#Presteps (first time only)

  1. Add the critic system as a repository: git remote add critic critic.myserver.com:/var/git/projectrepo.git

This assumes there is a critic server running at critic.myserver.com, and it will use the local name critic for that server.

#Simplest case

If only a single commit is to be reviewed and the commit message and description is good then it couldn't be simpler:

  1. Push the commit to a magical branch name (see the r/ prefix) to automatically create a review
    git push critic HEAD:r/myuniquereviewbranchname

Example

Done. The server will have given you the adress of the review and you can use that to do modifications, though it's already active so it's kind of late for that.

#Slightly more complex

  1. Push the commit(s) to the server:
    git push critic HEAD:myuniquereviewbranchname
  2. Go to the web interface at http://critic.myserver.com/ and Login.
  3. Select Branches from the top menu.
  4. Select repository, locate your myuniquereviewbranchname branch and select it.
  5. (optional) If the list of commits doesn't match the commits to be reviewed then select the wanted commits by drag-selecting.
  6. Click "Create Review" in the upper right corner.
  7. Fill in the necessary information for the reviewer.

#Result

Review page

Clone this wiki locally