Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russia is missing #40

Open
pschloss opened this issue Oct 8, 2024 · 1 comment
Open

Russia is missing #40

pschloss opened this issue Oct 8, 2024 · 1 comment
Labels
good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help! tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@pschloss
Copy link

pschloss commented Oct 8, 2024

I noticed that the gapminder site appears to have data for Russia, but it is missing from {gapminder}. If there's another release of the package it might be nice to have these data included.

Pat

@jennybc
Copy link
Owner

jennybc commented Oct 8, 2024

If I search this repo for "russia", it comes up quite frequently in the data preparation code:

https://github.com/search?q=repo:jennybc/gapminder%20russia&type=code

I can't immediately see any sort of explicit reason why Russia fell out of the dataset. It would take some sleuthing: re-running parts of the data prep code while keeping a specific eye on Russia to see when/why it disappears.

And then there's the question of whether to add it. Maybe? But it's not entirely clear. This dataset has various flaws and out-of-date qualities. It has become a bit like mtcars or iris. Fixing issues has some value, but so does stability.

In any case, I think it's worth some study.

@jennybc jennybc added good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help! tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help! tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

2 participants