From 20622c8dc87e808e42c51a2a986057ce52da6514 Mon Sep 17 00:00:00 2001 From: Jenny <32821331+jenny-s51@users.noreply.github.com> Date: Wed, 12 Oct 2022 10:17:05 -0400 Subject: [PATCH] chore(Card): removed isHoverable prop (#8196) * chore(card): remove isHoverable * update card snapshot --- packages/react-core/src/components/Card/Card.tsx | 5 +---- .../src/components/Card/__tests__/Card.test.tsx | 5 ----- .../Card/__tests__/__snapshots__/Card.test.tsx.snap | 12 ------------ 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/packages/react-core/src/components/Card/Card.tsx b/packages/react-core/src/components/Card/Card.tsx index e13e322a2be..c0203a42a9e 100644 --- a/packages/react-core/src/components/Card/Card.tsx +++ b/packages/react-core/src/components/Card/Card.tsx @@ -12,8 +12,6 @@ export interface CardProps extends React.HTMLProps, OUIAProps { className?: string; /** Sets the base component to render. defaults to article */ component?: keyof JSX.IntrinsicElements; - /** @deprecated to make a card hoverable, use isSelectable or isSelectableRaised. */ - isHoverable?: boolean; /** Modifies the card to include compact styling. Should not be used with isLarge. */ isCompact?: boolean; /** Modifies the card to include selectable styling */ @@ -70,7 +68,6 @@ export const Card: React.FunctionComponent = ({ id = '', className = '', component = 'article', - isHoverable = false, isCompact = false, isSelectable = false, isSelectableRaised = false, @@ -107,7 +104,7 @@ export const Card: React.FunctionComponent = ({ if (isSelectableRaised) { return css(styles.modifiers.selectableRaised, isSelected && styles.modifiers.selectedRaised); } - if (isSelectable || isHoverable) { + if (isSelectable) { return css(styles.modifiers.selectable, isSelected && styles.modifiers.selected); } return ''; diff --git a/packages/react-core/src/components/Card/__tests__/Card.test.tsx b/packages/react-core/src/components/Card/__tests__/Card.test.tsx index a3abc450479..70f47666b5e 100644 --- a/packages/react-core/src/components/Card/__tests__/Card.test.tsx +++ b/packages/react-core/src/components/Card/__tests__/Card.test.tsx @@ -37,11 +37,6 @@ describe('Card', () => { expect(screen.getByText('im a div')).toBeInTheDocument(); }); - test('card with isHoverable applied ', () => { - const { asFragment } = render(); - expect(asFragment()).toMatchSnapshot(); - }); - test('card with isCompact applied ', () => { const { asFragment } = render(); expect(asFragment()).toMatchSnapshot(); diff --git a/packages/react-core/src/components/Card/__tests__/__snapshots__/Card.test.tsx.snap b/packages/react-core/src/components/Card/__tests__/__snapshots__/Card.test.tsx.snap index d59d89794ef..6a3fadbff96 100644 --- a/packages/react-core/src/components/Card/__tests__/__snapshots__/Card.test.tsx.snap +++ b/packages/react-core/src/components/Card/__tests__/__snapshots__/Card.test.tsx.snap @@ -4,18 +4,6 @@ exports[`Card card with isCompact applied 1`] = `
- -`; - -exports[`Card card with isHoverable applied 1`] = ` - -