Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stapler implements Servlet API 2.5 which is pretty old #114

Closed
jtnord opened this issue May 8, 2017 · 1 comment
Closed

stapler implements Servlet API 2.5 which is pretty old #114

jtnord opened this issue May 8, 2017 · 1 comment

Comments

@jtnord
Copy link
Member

jtnord commented May 8, 2017

Stapler implements only the servlet 2.5 API - yet many applications now use 3.1 (either directly or indirectly_

If you attempt to directly use parts of the 3.1 API on a StaplerRequest or StaplerResponse then weird/bad things could happen depending on what you get underneath..
I have not observed any issues yet - but if you get a org.kohsuke.stapler.StaplerResponseWrapper rather than a org.kohsuke.stapler.ResponseImpl then things are liable to blow up. the same probably applies to StaplerRequest sub classes.

Apparantly (although no details are confirmed), this is causing some issues seen in the wild on the Jenkins project
@jglick
Copy link
Member

jglick commented Sep 11, 2017

Care to file a PR for it? IIUC the Jetty bundled in Jenkins implements 3.x so we could use this.

jtnord referenced this issue in jtnord/stapler Sep 20, 2017
@jtnord
[stapler#114] Update POM dependenceies to servet API 3.1.0
a03554c 
This also updates the JSP api to 2.30 as it is also part of Java EE 7
and so will be found in tandem with the servlet API.
jtnord referenced this issue in jtnord/stapler Sep 20, 2017
@jtnord
[Stapler#114] implement new required APIs for Servlet 3.1 API
259cf32
jtnord referenced this issue in jtnord/stapler Sep 20, 2017
@jtnord
[stapler#114] Update the example for Servelt 3.1.0
ce6bda2 
Mainly updates jetty and stapler to versions that use servlet 3.1.0 API
@jtnord jtnord mentioned this issue Sep 20, 2017
Merged
2 tasks
jglick referenced this issue Oct 10, 2017
@jglick
Merge pull request #131 from jtnord/servlet_3.x
dc2afaa 
[stapler#114] Update to Servlet API 3.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jglick @jtnord