Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Launcher#setNoCertificateCheck #696

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Remove deprecated Launcher#setNoCertificateCheck #696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/main/java/hudson/remoting/Launcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@
import java.nio.charset.StandardCharsets;
import java.nio.file.Path;
import java.security.GeneralSecurityException;
import java.security.KeyManagementException;
import java.security.NoSuchAlgorithmException;
import java.security.PrivilegedActionException;
import java.security.SecureRandom;
import java.security.cert.CertificateException;
Expand Down Expand Up @@ -220,20 +218,6 @@ public void setConnectTo(String target) {
connectionTarget = new InetSocketAddress(tokens[0],Integer.parseInt(tokens[1]));
}

/**
* Bypass HTTPS security check by using free-for-all trust manager.
*
* @param ignored
* This is ignored.
* @deprecated use {@link #noCertificateCheck}
*/
@Deprecated
public void setNoCertificateCheck(boolean ignored) throws NoSuchAlgorithmException, KeyManagementException {
System.out.println("Skipping HTTPS certificate checks altogether. Note that this is not secure at all.");

this.noCertificateCheck = true;
}

@Option(name="-noReconnect",aliases="-noreconnect",usage="Doesn't try to reconnect when a communication fail, and exit instead")
public boolean noReconnect = false;

Expand Down
Loading