From 1e35ab4c9db2690e0039ef1030c7347dc21ab7fe Mon Sep 17 00:00:00 2001 From: Sumit Sarin Date: Wed, 5 Aug 2020 00:22:34 +0530 Subject: [PATCH 1/4] testIsReadyWithoutPasswordWhenPasswordIsConfigured can throw IOException --- .../io/jenkins/plugins/redis/RedisAuthenticationTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java b/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java index 63974d72..12c0015b 100644 --- a/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java +++ b/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java @@ -39,6 +39,8 @@ import redis.clients.jedis.exceptions.JedisAccessControlException; import redis.clients.jedis.exceptions.JedisConnectionException; +import java.io.IOException; + import static org.hamcrest.Matchers.isA; import static org.hamcrest.core.Is.is; import static org.hamcrest.core.IsNot.not; @@ -102,7 +104,7 @@ public void testDeleteWithoutPasswordWhenPasswordIsConfigured() throws Exception } @Test - public void testIsReadyWithoutPasswordWhenPasswordIsConfigured() { + public void testIsReadyWithoutPasswordWhenPasswordIsConfigured() throws IOException { exceptionRule.expect(JedisConnectionException.class); exceptionRule.expectMessage(NO_RESOURCE_FROM_POOL); exceptionRule.expectCause(isA(JedisAccessControlException.class)); From 9f74f1f6409cbedafda4bc47107232f4c6d6ece2 Mon Sep 17 00:00:00 2001 From: Sumit Sarin Date: Wed, 5 Aug 2020 09:25:53 +0530 Subject: [PATCH 2/4] IOException -> Exception --- .../java/io/jenkins/plugins/redis/RedisAuthenticationTest.java | 2 +- pom.xml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java b/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java index 12c0015b..fa22337d 100644 --- a/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java +++ b/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java @@ -104,7 +104,7 @@ public void testDeleteWithoutPasswordWhenPasswordIsConfigured() throws Exception } @Test - public void testIsReadyWithoutPasswordWhenPasswordIsConfigured() throws IOException { + public void testIsReadyWithoutPasswordWhenPasswordIsConfigured() throws Exception { exceptionRule.expect(JedisConnectionException.class); exceptionRule.expectMessage(NO_RESOURCE_FROM_POOL); exceptionRule.expectCause(isA(JedisAccessControlException.class)); diff --git a/pom.xml b/pom.xml index e2e1957b..b4827b7b 100644 --- a/pom.xml +++ b/pom.xml @@ -42,7 +42,8 @@ THE SOFTWARE. - 2.248 + 2.251-SNAPSHOT + ../jenkins/ 8 true From 03ad120e85848931baf7c2f8d0fa1c509ed91c0d Mon Sep 17 00:00:00 2001 From: Sumit Sarin Date: Wed, 5 Aug 2020 09:26:16 +0530 Subject: [PATCH 3/4] Remove redundant import --- .../java/io/jenkins/plugins/redis/RedisAuthenticationTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java b/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java index fa22337d..819ac28e 100644 --- a/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java +++ b/plugin/src/test/java/io/jenkins/plugins/redis/RedisAuthenticationTest.java @@ -39,8 +39,6 @@ import redis.clients.jedis.exceptions.JedisAccessControlException; import redis.clients.jedis.exceptions.JedisConnectionException; -import java.io.IOException; - import static org.hamcrest.Matchers.isA; import static org.hamcrest.core.Is.is; import static org.hamcrest.core.IsNot.not; From b53b770e5e5ccf2112e860b0c338502e126e4817 Mon Sep 17 00:00:00 2001 From: Sumit Sarin Date: Wed, 5 Aug 2020 09:32:56 +0530 Subject: [PATCH 4/4] Undo jenkins version change --- pom.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index b4827b7b..e2e1957b 100644 --- a/pom.xml +++ b/pom.xml @@ -42,8 +42,7 @@ THE SOFTWARE. - 2.251-SNAPSHOT - ../jenkins/ + 2.248 8 true