Upgraded apt module dependency to support v2 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
works for me, cheers 👍 |
|
This is my preferred solution as well and have gotten it merged into other modules. 👍 |
This was referenced Jun 24, 2015
rtyler
pushed a commit
that referenced
this pull request
Jun 26, 2015
Upgraded apt module dependency to support v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #301.
When they released the v2.0 version of the apt module, the folks at Pupperlabs also broke backwards compatibility. This caused a lot of problems, so they've gone back and released a v2.1 that adds support for the v1 way of doing things.
What this means is that it's better so support the old way of doing things than the new way, as the old way has the largest compatibility spread. In my previous pull request (which was made before the apt v2.1 release was made) I attempted to support both version of the module, but this accomplishes that much better.
There is one caveat though- this module will not support v2.0 of the apt module, and unfortunately there is no way to exclude specific versions of dependencies in the metadata.json file. This means there's no way to prevent this module from being installed next to an incompatible module, but I think that's a reasonable decision to make since this module otherwise won't be usable with any of the v2 line at all.