From 5b17d5ecb960a0c3a591495e107bd0f985df4899 Mon Sep 17 00:00:00 2001 From: Basil Crow Date: Tue, 22 Nov 2022 08:35:01 -0800 Subject: [PATCH] Remove unnecessary SpotBugs exclusions (#126) --- .../org/kohsuke/accmod/restrictions/ProtectedExternally.java | 2 +- .../src/main/java/org/kohsuke/accmod/impl/EnforcerMojo.java | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/access-modifier-annotation/src/main/java/org/kohsuke/accmod/restrictions/ProtectedExternally.java b/access-modifier-annotation/src/main/java/org/kohsuke/accmod/restrictions/ProtectedExternally.java index 35ed0da..8b9b464 100644 --- a/access-modifier-annotation/src/main/java/org/kohsuke/accmod/restrictions/ProtectedExternally.java +++ b/access-modifier-annotation/src/main/java/org/kohsuke/accmod/restrictions/ProtectedExternally.java @@ -50,7 +50,7 @@ public class ProtectedExternally extends None { @Override @SuppressFBWarnings( - value={"RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE","RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE", "NP_LOAD_OF_KNOWN_NULL_VALUE"}, + value={"RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE", "NP_LOAD_OF_KNOWN_NULL_VALUE"}, justification="something in this class confuses spotbugs, I can't see anything redundant and the error line is the catch block") public void invoked(Location loc, RestrictedElement target, ErrorListener errorListener) { if (target.isInTheInspectedModule()) { diff --git a/access-modifier-checker/src/main/java/org/kohsuke/accmod/impl/EnforcerMojo.java b/access-modifier-checker/src/main/java/org/kohsuke/accmod/impl/EnforcerMojo.java index e1eea5a..b124f33 100644 --- a/access-modifier-checker/src/main/java/org/kohsuke/accmod/impl/EnforcerMojo.java +++ b/access-modifier-checker/src/main/java/org/kohsuke/accmod/impl/EnforcerMojo.java @@ -55,12 +55,9 @@ public class EnforcerMojo extends AbstractMojo { @Override @SuppressFBWarnings(value = { - "UWF_UNWRITTEN_FIELD", "URLCONNECTION_SSRF_FD", - "UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD", "PATH_TRAVERSAL_IN", - "DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED", - "NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD" + "DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED" }) public void execute() throws MojoExecutionException, MojoFailureException { if (skip) {