Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with agent injection in mind #1606

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

Vlatombe
Copy link
Member

Following #1602, there are several sentences in the README that can be made more generic, avoiding references to jnlp. As it is still the default value, I couldn't remove all references, but I think it is slightly clearer now.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Following jenkinsci#1602, there are several sentences in the README that can be
made more generic, avoiding references to `jnlp`. As it is still the
default value, I couldn't remove all references, but I think it is
slightly clearer now.
@Vlatombe Vlatombe requested a review from a team as a code owner September 17, 2024 15:52
README.md Outdated Show resolved Hide resolved
@Vlatombe Vlatombe merged commit 93ea4bb into jenkinsci:master Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants