Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72261] allow custom implementation for removing/update pod templates #1465

Merged
merged 11 commits into from
Nov 8, 2023

Conversation

scherler
Copy link
Contributor

@scherler scherler commented Oct 31, 2023

https://issues.jenkins.io/browse/JENKINS-72261

Testing done

Submitter checklist

Preview Give feedback

Signed-off-by: Thorsten Scherler <scherler@gmail.com>
Signed-off-by: Thorsten Scherler <scherler@gmail.com>
Signed-off-by: Thorsten Scherler <scherler@gmail.com>
Signed-off-by: Thorsten Scherler <scherler@gmail.com>
Signed-off-by: Thorsten Scherler <scherler@gmail.com>
Signed-off-by: Thorsten Scherler <scherler@gmail.com>
@scherler scherler requested a review from a team as a code owner October 31, 2023 12:33
Signed-off-by: Thorsten Scherler <scherler@gmail.com>
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall.

scherler and others added 2 commits November 8, 2023 09:27
Co-authored-by: Vincent Latombe <vincent@latombe.net>
Signed-off-by: Thorsten Scherler <scherler@gmail.com>
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vlatombe Vlatombe enabled auto-merge November 8, 2023 14:38
@Vlatombe Vlatombe merged commit 758a0c6 into jenkinsci:master Nov 8, 2023
5 checks passed
@Vlatombe Vlatombe added the enhancement Improvements label Nov 8, 2023
@scherler scherler deleted the JENKINS-72261 branch November 8, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants