-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-68126] Remove event streaming causing performance problems at scale #1192
Conversation
…esLauncher.java Co-authored-by: Jesse Glick <jglick@cloudbees.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to involve a loss of some diagnosability, but that seems an acceptance price to pay for the scalability improvement (and code simplification).
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesLauncher.java
Outdated
Show resolved
Hide resolved
src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorTest.java
Outdated
Show resolved
Hide resolved
...java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorWindowsTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Note that automatic release after matching labels is currently not reliable, possibly due to a race condition in GitHub (being investigated); if you wish, you can force a release with Run workflow at https://github.com/jenkinsci/kubernetes-plugin/actions/workflows/cd.yaml. |
This removal puts us in a bind for providing user feedback on builds. Previously, this would inform them that their pod wasn't scheduled due to lack of resources or other capacity issues. Now we're back to a "spinning beachball" setup - a user needs to ping platform owners to investigate why a pod isn't running. |
It would be great to readd support for streaming agent pod event messages (and also pod logs) to the build log, if this can be done without burdening either the controller or the API server. |
Amends #1167