Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68126] Remove event streaming causing performance problems at scale #1192

Merged
merged 11 commits into from
Jun 8, 2022

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jun 7, 2022

Amends #1167

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe added the bug Bug Fixes label Jun 7, 2022
@Vlatombe Vlatombe requested a review from jglick June 7, 2022 11:59
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to involve a loss of some diagnosability, but that seems an acceptance price to pay for the scalability improvement (and code simplification).

Vlatombe and others added 2 commits June 8, 2022 09:10
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@Vlatombe Vlatombe merged commit 84ba1de into master Jun 8, 2022
@jglick
Copy link
Member

jglick commented Jun 8, 2022

Note that automatic release after matching labels is currently not reliable, possibly due to a race condition in GitHub (being investigated); if you wish, you can force a release with Run workflow at https://github.com/jenkinsci/kubernetes-plugin/actions/workflows/cd.yaml.

@MattLud
Copy link
Contributor

MattLud commented Aug 25, 2022

Seems to involve a loss of some diagnosability, but that seems an acceptance price to pay for the scalability improvement (and code simplification).

This removal puts us in a bind for providing user feedback on builds.

Previously, this would inform them that their pod wasn't scheduled due to lack of resources or other capacity issues.

Now we're back to a "spinning beachball" setup - a user needs to ping platform owners to investigate why a pod isn't running.

@jglick jglick deleted the JENKINS-68126 branch August 30, 2022 18:42
@jglick
Copy link
Member

jglick commented Aug 30, 2022

It would be great to readd support for streaming agent pod event messages (and also pod logs) to the build log, if this can be done without burdening either the controller or the API server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants