Missing summary in check when no test results recorded

[jglick]

Not sure if this is related to #211.

https://github.com/jenkinsci/bom/runs/1498792384 and all other plugin branches show no test result count. Only the initial https://github.com/jenkinsci/bom/runs/1498759937 displays

passed: 8

as expected.

[jglick]

(I do not consider this particularly important, unless test failures are not reported either. Have not yet observed an unstable build to check.)

[mrginglymus]

I'm seeing test result counts on most runs except durable task and echarts. Currently stuck under toddler and wrangling GitHub's very limited app, so hard to see exactly what's gone on.

[mrginglymus]

[timja]

ah interesting, I expect this will trigger some failures: jenkinsci/bom#376

[mrginglymus]

💥

[jglick]

So we do get details on failures; it is only the count which is missing on subsequent checks.

[mrginglymus]

Everything looks ok to me - iirc you don’t get a count when there’s a single failure, right? And the greens with no counts also didn’t have any tests.

That’s definitely something to improve though, to explicitly say ‘no tests found’ rather than not show a count

[jglick]

the greens with no counts also didn’t have any tests

Ah, missed that in https://github.com/jenkinsci/bom/runs/1498880553 for example. (jenkinsci/bom#341 means that this was common, for plugins including no explicit tests.) Maybe better to just omit the check altogether if there were no tests (when allowEmptyResults: true)?

[mrginglymus]

Yes - I suppose once you’ve set that true you shouldn’t be surprised if you get no results :)

[timja]

Possibly just put in the summary:

No test results found

?

A little bit wary of omitting but also could be a valid solution

[mrginglymus]

That would be my preference but I’ve never used ‘allow empty results’ so can’t speak from experience.

Doesn’t seem worth adding another config...

[timja]

Doesn’t seem worth adding another config...

agree