Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile Runner App ZIP and Fat JAR include WARs and plugin JARs while they should not #226

Closed
oleg-nenashev opened this issue Nov 6, 2019 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@oleg-nenashev
Copy link
Member

Current design of Jenkinsfile Runner presumes that the plugins are passed using a directory (-p option, even if they are mandatory for the JFR well-being). The idea is that the plugin JARs should not be included, but apparently they are bundled in recent JFR versions. It might related to recent Maven Assembly Plugin

image

@oleg-nenashev oleg-nenashev added the bug Something isn't working label Nov 6, 2019
@oleg-nenashev oleg-nenashev changed the title Jenkinsfile Runner App ZIP and Fat JAR include plugin JARs while they should not Jenkinsfile Runner App ZIP and Fat JAR include WARs and plugin JARs while they should not Jul 29, 2020
@oleg-nenashev oleg-nenashev added this to the jfr-1.0 milestone Jul 29, 2020
@oleg-nenashev
Copy link
Member Author

I am working on it. Likely I will create two bundles: one without any plugins and the Jenkins WAR, and another portable JAR which includes them

@oleg-nenashev
Copy link
Member Author

#449 fixed that. Now we have "slim" packaging which does not include WARs and JARs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant