From 8ee3539ad04a3bda2dc3f6e0bf427275996bc9e8 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Sat, 23 Dec 2023 23:01:41 -0700 Subject: [PATCH] Use spotbugs plugin 4.8.2.0 with additional suppressions https://github.com/jenkinsci/pom/pull/510 needs this change along with checks of the other repositories that use the Jenkins parent pom. https://github.com/jenkinsci/pom/pull/501#pullrequestreview-1718536231 recommends that the new spotbugs issues be either suppressed or resolved in the upstream release of spotbugs. This change suppresses the new warning for primitive fields that are pu9blicly visible and the new warning for a few cases where a field could be made static. This change skips the warnings related to CT_CONSTRUCTOR_THROWS because they are not relevant to Jenkins. https://github.com/jenkinsci/plugin-pom/pull/869#issuecomment-1860918407 provides more details along with the discussion at https://github.com/spotbugs/spotbugs/issues/2695 --- core/src/spotbugs/excludesFilter.xml | 123 +++++++++++++++++++++++++++ pom.xml | 4 + 2 files changed, 127 insertions(+) diff --git a/core/src/spotbugs/excludesFilter.xml b/core/src/spotbugs/excludesFilter.xml index af99fff5055f..7d36952fc372 100644 --- a/core/src/spotbugs/excludesFilter.xml +++ b/core/src/spotbugs/excludesFilter.xml @@ -53,6 +53,125 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + 4.13 + + + 4.8.2.0 Max + FindReturnRef,ConstructorThrow Medium 1.33