Upgrade HtmlUnit from 2.x.x to 3.x.x

[basil]

Problem

The Jenkins test harness depends on an outdated release of HtmlUnit (at the time of this writing, 2.70.0).

Solution

Upgrade HtmlUnit from its current version (at the time of this writing, 2.70.0) to the latest version (at the time of this writing, 3.0.0) in jenkins-test-harness-htmlunit, jenkins-test-harness, plugin-pom, Stapler, and Jenkins core.

Implementation

Consult the Migrating from HtmlUnit 2.x.x to HtmlUnit 3.x.x documentation:

1. Adjust the Maven group ID to org.htmlunit: 👉 HTMLUnit 3.x jenkins-test-harness-htmlunit#110

   <dependency>
       <groupId>org.htmlunit</groupId>
       <artifactId>htmlunit</artifactId>
       <version>3.0.0</version>
   </dependency>

2. Change all package name references from net.sourceforge.htmlunit to org.htmlunit: 👉 Upgrade to htmlunit 3.x #589

   import org.htmlunit.BrowserVersion;
   import org.htmlunit.WebClient;
   import org.htmlunit.html.HtmlInput;
   import org.htmlunit.html.HtmlPage;

3. Update input control value access by replacing all usages of org.htmlunit.html.HtmlInput.getValueAttribute() with org.htmlunit.html.HtmlInput.getValue() and replacing all usages of org.htmlunit.html.HtmlInput.setValueAttribute(String) with org.htmlunit.html.HtmlInput.setValue(String).

Success criteria

The success criteria for this ticket are as follows:

• jenkins-test-harness-htmlunit released with the latest version of HtmlUnit (at the time of this writing, 3.0.0) 👉 HTMLUnit 3.x jenkins-test-harness-htmlunit#110
• jenkins-test-harness upgraded to the abovementioned release of jenkins-test-harness-htmlunit 👉 Upgrade to htmlunit 3.x #589
• plugin-pom upgraded to the abovementioned release of jenkins-test-harness
• Stapler upgraded to the abovementioned release of jenkins-test-harness-htmlunit 👉 Update htmlunit to 3.x stapler#464
• Jenkins core upgraded to the abovementioned release of jenkins-test-harness 👉 Update htmlunit to 3.x jenkins#8050
• Weekly release shipped with all of the above changes

[ggold7046]

Hi, I'm looking for some testing issues. Could anyone guide me how to find it ?

[MarkEWaite]

Hi, I'm looking for some testing issues. Could anyone guide me how to find it ?

If you're interested in helping with this issue, then a careful reading of the instructions in this issue description will be enough to let you start contributing to help with this issue.

If you're looking for an issue to help that is different than this issue, then the Jenkins chat channels like https://app.gitter.im/#/room/#jenkinsci_newcomer-contributors:gitter.im are much more likely to offer ideas and suggestions.

[jglick]

@timja I suppose this can now be closed?

[timja]

I think so there’s still a long tail of plugins in https://docs.google.com/spreadsheets/d/1ih_gVd9uhxLw4BZ6IeJGrYsvu-DvIF0xovu4wZbaXy8/edit

But unsure if we need to keep this open

[basil]

I don't think we can declare victory until more of the orange and red rows in that spreadsheet turn green or yellow. There is still a large amount of work that remains to be completed.

[basil]

jenkinsci/next-build-number-plugin#18 demonstrates the confusion that ensues when PRs are filed without context or a clean build.

[basil]

With the exception of Job Import, critical plugins with over 10,000 installations have been migrated.