-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Linux): switch from temurin base images to temurin installer #786
feat(Linux): switch from temurin base images to temurin installer #786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the size of the PR (which will make it a nightmare to review), how do you feel about splitting Linux/Windows into 2 distinct PRs so we can focus on 1 paltform then on the other?
You were the one saying that all images should be done at once, as you want ^^ For the record, all images have been switched, with the Windows ones using the "happy path" of Adoptium API. |
Note that splitting this PR in two parts will result in updatecli failing until both will be merged: I'm using the original version containing Also, that PR is (IMO) not that much complicated:
Happy to do an interactive review if needed, can also split the PR anyway, your call 🙂 |
#787 has been merged: you can proceed with this one (gotta spend some time on it to ensure it is delivered soon). |
85c6e73
to
eeb8230
Compare
1bc768c
to
c6d89bc
Compare
c6d89bc
to
3c4c191
Compare
This PR switches from temurin base images to the temurin installer in Linux images.
Benefits:
Notes:
Removed the TARGETPLATFORM check in Alpine images as we're not publishing any arm/v7 image of this kindIntegrate jlink improvements from chore: keep only one Dockerfile per Linux image variant docker#1857Ref:
jenkins/*
container images on DockerHub errors withHTTP/429
jenkins-infra/helpdesk#4029 (comment)Testing done
Local builds + CI
Submitter checklist