Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Linux): switch from temurin base images to temurin installer #786

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Apr 15, 2024

This PR switches from temurin base images to the temurin installer in Linux images.

Benefits:

  • Less layers to pull
  • Faster availability as we don't need to wait for every kind of images (OS/architecture) to be released
  • Simpler updatecli manifests

Notes:

Ref:

Testing done

Local builds + CI

Submitter checklist

alpine/Dockerfile Outdated Show resolved Hide resolved
alpine/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the size of the PR (which will make it a nightmare to review), how do you feel about splitting Linux/Windows into 2 distinct PRs so we can focus on 1 paltform then on the other?

@lemeurherve
Copy link
Member Author

lemeurherve commented Apr 17, 2024

Given the size of the PR (which will make it a nightmare to review), how do you feel about splitting Linux/Windows into 2 distinct PRs so we can focus on 1 paltform then on the other?

You were the one saying that all images should be done at once, as you want ^^
EDIT: misheard you, you were speaking about coordinate releases.

For the record, all images have been switched, with the Windows ones using the "happy path" of Adoptium API.

@lemeurherve
Copy link
Member Author

lemeurherve commented Apr 17, 2024

Note that splitting this PR in two parts will result in updatecli failing until both will be merged: I'm using the original version containing +, not converted to _.

Also, that PR is (IMO) not that much complicated:

  • All Linux image changes are more or less the same, with a code already present elsewhere and in this repo history.
  • The Windows images needed a new parameter passed at test time, the JAVA_VERSION

Happy to do an interactive review if needed, can also split the PR anyway, your call 🙂

@dduportal
Copy link
Contributor

#787 has been merged: you can proceed with this one (gotta spend some time on it to ensure it is delivered soon).

@lemeurherve lemeurherve force-pushed the helpdesk4029-switch-off-from-eclipse-temurin-base-images branch 2 times, most recently from 85c6e73 to eeb8230 Compare May 4, 2024 14:09
@lemeurherve lemeurherve force-pushed the helpdesk4029-switch-off-from-eclipse-temurin-base-images branch from 1bc768c to c6d89bc Compare May 6, 2024 20:51
@lemeurherve lemeurherve force-pushed the helpdesk4029-switch-off-from-eclipse-temurin-base-images branch from c6d89bc to 3c4c191 Compare May 6, 2024 21:43
@lemeurherve lemeurherve marked this pull request as ready for review May 6, 2024 21:44
@lemeurherve lemeurherve requested a review from a team as a code owner May 6, 2024 21:44
@lemeurherve lemeurherve requested a review from dduportal May 6, 2024 21:44
@lemeurherve lemeurherve changed the title feat: switch from temurin base images to temurin installer feat(Linux): switch from temurin base images to temurin installer May 6, 2024
alpine/Dockerfile Outdated Show resolved Hide resolved
@dduportal dduportal merged commit a37e97a into jenkinsci:master May 7, 2024
10 checks passed
@lemeurherve lemeurherve deleted the helpdesk4029-switch-off-from-eclipse-temurin-base-images branch May 7, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants