Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins Pipeline script edit page #127

Closed
s1mple-child opened this issue Jul 29, 2020 · 2 comments · Fixed by jenkinsci/workflow-cps-plugin#654 or #319
Closed

Jenkins Pipeline script edit page #127

s1mple-child opened this issue Jul 29, 2020 · 2 comments · Fixed by jenkinsci/workflow-cps-plugin#654 or #319
Labels
plugin-compatibility Issues with plugin compatibility

Comments

@s1mple-child
Copy link

Hi, Developer:

I found dark theme for Jenkins from the blog posted on Jenkins official blog page. And used for a while, I think it's awesome.Thanks for your fantastic job. 👍

I found one place.When I created a pipeline job and used Pipeline script option not Pipeline script from SCM and develop my pipeline script, I found the pipeline script edit page color is still white. If this page color as same as Jenkins main page theme, I think it will looks more coordinate.

This is my suggestion.Thanks for your feedback. ❤️

@timja
Copy link
Member

timja commented Jul 29, 2020

Hi thanks for the feedback.

I’ve looked at fixing this previously.
I’m just not sure the best way to do it,

I think it needs an extension point in the pipeline plugin that provides this.

That would be quite straightforward for plain dark theme, but I don’t know how to handle supporting the OS respecting setting. We may need to fork the dark theme for the editor and add our own which includes the required css which probably is the most straightforward approach

@s1mple-child
Copy link
Author

Hi thanks for the feedback.

I’ve looked at fixing this previously.
I’m just not sure the best way to do it,

I think it needs an extension point in the pipeline plugin that provides this.

That would be quite straightforward for plain dark theme, but I don’t know how to handle supporting the OS respecting setting. We may need to fork the dark theme for the editor and add our own which includes the required css which probably is the most straightforward approach

Yeah, you are right.I almost forget this plain is provided by Jenkins pipeline: Groovy plugin.

Because I'm a Windows user, so I can't sonsider much of OS problem. As a developer it's necessary to consider this. But it's an optional job I think. If some more important jobs in your todo list, I think you can put this in the future. Maybe someday the plugin provide dark theme. 😆

Also thanks for your feedback. Looking forward to your next update version. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin-compatibility Issues with plugin compatibility
Projects
None yet
2 participants