From e31be400ecbb3922a73d809ba8e5165aae85b76c Mon Sep 17 00:00:00 2001
From: Mark Waite <mark.earl.waite@gmail.com>
Date: Tue, 12 Sep 2023 17:23:31 -0600
Subject: [PATCH] Allow developer control of parallel testing

Move the definition of parallel testing from the Maven pom file into the
Jenkinsfile so that ci.jenkins.io continues to run the tests with one
process per available core, while developers are allowed to configure
the amount of parallel testing based on the configuration and use of
their computer.

Developers can adjust parallel execution by passing a command line
argument to Maven like this:

  mvn clean -DforkCount=1C verify

Developers can define a Maven profile that sets the forkCount in their
~/.m2/settings.xml like this:

  <profile>
    <id>faster</id>
    <activation>
      <activeByDefault>true</activeByDefault>
    </activation>
    <properties>
      <forkCount>.45C</forkCount>
    </properties>
  </profile>

With that entry in the settings.xml file, then 0.45C will be used for:

  mvn clean verify
---
 Jenkinsfile |  2 +-
 pom.xml     | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/Jenkinsfile b/Jenkinsfile
index a0b5acc3..595b4741 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -1,4 +1,4 @@
-buildPlugin(useContainerAgent: true, failFast: false, configurations: [
+buildPlugin(useContainerAgent: true, failFast: false, forkCount: '1C', configurations: [
   [platform: 'linux', jdk: 17],
   [platform: 'windows', jdk: 11],
 ])
diff --git a/pom.xml b/pom.xml
index 552fdd72..0b6672c9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -164,18 +164,6 @@
     <build>
         <defaultGoal>clean test install</defaultGoal>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-surefire-plugin</artifactId>
-                <configuration>
-                    <parallel>all</parallel>
-                    <useUnlimitedThreads>true</useUnlimitedThreads>
-                    <forkCount>1C</forkCount>
-                    <systemPropertyVariables>
-                        <ui.loading.timeout>${ui.loading.timeout}</ui.loading.timeout>
-                    </systemPropertyVariables>
-                </configuration>
-            </plugin>
             <!-- TODO: re-enable, probably with google-chrome headless or qunit/npm instead
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>