fix: switch to Adoptium Temurin installer instead of Docker image #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing the build failures on #150 #151 and #152 (ref. jenkins-infra/helpdesk#4058) as the Docker images of Adoptium Temurin are not available for the last JDK versions, by using the Temurin installer instead of the docker image. Inspired by jenkinsci/docker-agent#787
It introduces the following changes:
python-core
stage which uses a Windows Server Core base:misexec.exe
does not exist on Nanoserver.ARG JAVA_VERSION
into the Python stage's scope as a consequence to avoid repetition out and in the scopeARG JAVA_VERSION
build arguments is changed to allow using the same download code (for future factorization), which breaks theupdatecli
for now (see notes below):jdk-
is added for JDK11, JDK17 and JDK21. The prefixjdk
is added for JDK8.+
is usedinstead of_
to avoid further transformations: the Docker images where using_
for their tagsnetapi32
DLL and `whoami.exe`` from the Python parent image instead of Temurin imageDockerfile
s are as close as possibleNotes:
updatecli
manifests are changed: This PR breaks the current manifests. A subsequent PR is required to fix them.jlink
to "tune" the JDK but can be done on subsequent PR (cc @lemeurherve for info). But the JDK is installed intoC:\javaruntime
which is static.docker build
, it does not supportdocker-compose.yml
and Windows container do not work with Docker BuildX.