Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive example should be updated #272

Closed
yoichi opened this issue Jan 22, 2022 · 2 comments
Closed

False positive example should be updated #272

yoichi opened this issue Jan 22, 2022 · 2 comments

Comments

@yoichi
Copy link

yoichi commented Jan 22, 2022

Follow the instruction in README.md with vulture >= 2.1 results:

$ vulture dead_code.py
dead_code.py:1: unused import 'os' (90% confidence)
dead_code.py:8: unused variable 'message' (60% confidence)

It does not detect

dead_code.py:4: unused function 'greet' (60% confidence)

as expected since #219 eliminates the false positive.

I think it would be good to update the example to something that can still be reproduced.

@yoichi yoichi changed the title False positive example cannot be reproduced False positive example should be updated Jan 22, 2022
@RJ722
Copy link
Contributor

RJ722 commented Jan 22, 2022

Thanks for the report, @yoichi! I'll get a fix up for this.

@jendrikseipp
Copy link
Owner

Fixed now. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants