Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

porcelain: respect 'abbrev' argument when describing annotated-tagless repositories #1482

Merged
merged 9 commits into from
Jan 25, 2025
Merged

porcelain: respect 'abbrev' argument when describing annotated-tagless repositories #1482

merged 9 commits into from
Jan 25, 2025

Conversation

jayaddison
Copy link
Contributor

Resolves #1477.

@jayaddison jayaddison requested a review from jelmer as a code owner January 23, 2025 12:37
jelmer
jelmer reviewed Jan 23, 2025
View reviewed changes
dulwich/porcelain.py Outdated Show resolved Hide resolved
@jayaddison jayaddison marked this pull request as draft January 23, 2025 14:57
jayaddison
jayaddison commented Jan 23, 2025
View reviewed changes
dulwich/porcelain.py Outdated Show resolved Hide resolved
@jayaddison jayaddison marked this pull request as ready for review January 23, 2025 17:12
jayaddison
jayaddison commented Jan 23, 2025
View reviewed changes
dulwich/porcelain.py Outdated Show resolved Hide resolved
jayaddison
jayaddison commented Jan 24, 2025
View reviewed changes
dulwich/porcelain.py Outdated Show resolved Hide resolved
@jayaddison
Copy link
Contributor Author

@jelmer I think this is ready for re-review. Apologies for not noticing the missing g prefix in the short-circuit (re)implementation!

@jelmer
Copy link
Owner

jelmer commented Jan 25, 2025

@jayaddison changes look good, but please run "ruff format"

@jelmer jelmer enabled auto-merge January 25, 2025 18:01
auto-merge was automatically disabled January 25, 2025 18:36

Head branch was pushed to by a user without write access

@jelmer jelmer enabled auto-merge January 25, 2025 21:59
@jelmer jelmer disabled auto-merge January 25, 2025 21:59
@jelmer jelmer enabled auto-merge (squash) January 25, 2025 21:59
@jelmer jelmer disabled auto-merge January 25, 2025 22:13
@jelmer jelmer merged commit b6dd496 into jelmer:master Jan 25, 2025
9 of 25 checks passed
@jayaddison jayaddison deleted the issue-1477/unique-abbrev-prefix-length branch January 26, 2025 11:26
@jayaddison
Copy link
Contributor Author

Thanks @jelmer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelmer jelmer jelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

porcelain: 'abbrev' parameter is ignored when describing tagless repositories
2 participants
@jayaddison @jelmer