Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libraries maybe not being displayed in TV layout #4871

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix libraries maybe not being displayed in TV layout #4871

merged 1 commit into from
Oct 12, 2023

Conversation

thornbill
Copy link
Member

Changes
Ensures that libraries are visible on the home screen when using the TV layout since the hamburger menu is unavailable

Issues
Fixes #4450

@thornbill thornbill added the bug Something isn't working label Oct 10, 2023
@thornbill thornbill added this to the v10.9.0 milestone Oct 10, 2023
@thornbill thornbill requested a review from a team as a code owner October 10, 2023 20:53
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit a31314a
Status ✅ Deployed!
Preview URL https://39378f65.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

dmitrylyzo
dmitrylyzo approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A long time ago, I tried enabling the menu drawer on TV. It worked, iirc, but exiting from it (navigate to the right) was glitchy.

@thornbill thornbill merged commit 188d6c3 into jellyfin:master Oct 12, 2023
22 checks passed
@thornbill thornbill deleted the show-libs-tv branch October 12, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v10.9.0
Development

Successfully merging this pull request may close these issues.

[Issue]: No way to change libraries in "TV" mode
3 participants
@thornbill @jellyfin-bot @dmitrylyzo