Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for 4080 and more 4090 stores #3104

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

bobbydp
Copy link
Contributor

@bobbydp bobbydp commented Dec 8, 2022

(US - Amazon, Best Buy, Microcenter, PNY, Zotac)
Merge from limboed pull request by Mr-Tech-13 and used PR 3085 as a template

Description

I cherry picked the salient Mr-Tech-13 modifications for the stores that I am able to visit and read (US Based Stores)

Testing

running locally with a handful of the add to cart links on 4080 working. Admittedly I copied some of Mr-Tech-13s 4080 URLs wholesale trusting that those are genuine and work. 4090 links I was more particular about and pasting them into browser to ensure they are active.

(US - Amazon, Best Buy, Microcenter, PNY, Zotac)
Merge from previous pull request from Mr-Tech-13 and used PR 3085 as a template
@bobbydp bobbydp requested a review from jef as a code owner December 8, 2022 19:37
@bobbydp
Copy link
Contributor Author

bobbydp commented Dec 8, 2022

I incorporated some clean up of redundant 4090 entries on B&H and Newegg as well from a past PR I closed.

jef
jef previously approved these changes Jan 19, 2023
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you 🙇

@jef jef enabled auto-merge (squash) January 19, 2023 09:13
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made some linting changes. Should be good now! Thanks again :)

@jef jef merged commit d8915cf into jef:main Jan 19, 2023
@bobbydp
Copy link
Contributor Author

bobbydp commented Jan 19, 2023

FWIW, I got my 4090 2 weeks ago thanks to you and this wonderful tool!! Appreciate you greatly

@jef
Copy link
Owner

jef commented Apr 12, 2023

@bobbydp Thanks for adding these in and congrats on your new 4090!!! And thanks for letting me know, love hearing these stories :)

jef pushed a commit that referenced this pull request Jan 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.9.0](v3.8.3...v3.9.0)
(2023-05-15)


### Features

* add support for 4080 and more 4090 stores
([#3104](#3104))
([d8915cf](d8915cf))


### Bug Fixes

* update Target's url for PS5 Console
([#3098](#3098))
([5eb7c12](5eb7c12))


### Documentation

* fix badge
([bb01bed](bb01bed))
* use main branch for badge
([8dab4bb](8dab4bb))


### Miscellaneous

* remove dependabot
([850f5c8](850f5c8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants