Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(canadacomputers): add 3060 card #2028

Merged
merged 2 commits into from
Feb 25, 2021
Merged

chore(canadacomputers): add 3060 card #2028

merged 2 commits into from
Feb 25, 2021

Conversation

gmalette
Copy link
Contributor

Description

Introduce the 3060 card and add canadacomputers, memoryexpress, bestbuy-ca, and newegg-ca configs.

Testing

Ran the program and made sure they were all out of stock 🙈.

@gmalette gmalette requested a review from jef as a code owner February 25, 2021 18:47
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@jef jef merged commit 1288f92 into jef:main Feb 25, 2021
@jef
Copy link
Owner

jef commented Feb 25, 2021

I forgot to mention, do you mind added documentation? If you aren't available, I can add it in later.

Thanks!

erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants