fix(discord): ensure first group in list is notified #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix ensures that the `series` of a `link` is found in `notifyGroupSeries`. Before this fix, the first key in `notifyGroupSeries` was excluded.
jef
approved these changes
Jan 25, 2021
jef
changed the title
erwinc1
pushed a commit
to erwinc1/streetmerchant
that referenced
this pull request
Mar 31, 2021
This fix ensures that the `series` of a `link` is found in `notifyGroupSeries`. Before this fix, the first key in `notifyGroupSeries` was excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix ensures that the
seriesof alinkis found innotifyGroupSeries. Before this fix, the first key innotifyGroupSerieswas excluded. Typically, the first key is3070, so Discord notifications wouldn't include an@mentionfor the3070role. This fixes that bug.