Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(computeruniverse): add 3060ti cards #1665

Merged
merged 4 commits into from
Jan 14, 2021

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Jan 12, 2021

Description

Fixes #1660

  • Updated computeruniverse.ts with several dozen 3060ti cards.
  • Updated store.ts with additional 3060ti models
  • Updated filter.md to reflect additional models in documentation

Testing

image

works as intended

- Added additional 3060ti cards to store
- updated filter.md to fit additional card types per manufacturer
@wofnull wofnull requested a review from jef as a code owner January 12, 2021 17:06
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you very much for the contribution.

@wofnull
Copy link
Contributor Author

wofnull commented Jan 12, 2021

Same as in #1664 :
build and lint fails on twitch.ts, which was not touched, and base was pulled directly from master.

@jef
Copy link
Owner

jef commented Jan 12, 2021

Sorry about the linting. I'm going to make a fix and we can merge that in.

Thank you!

@jef jef changed the title feat(computeruniverse): added 3060ti cards chore(computeruniverse): add 3060ti cards Jan 14, 2021
@jef jef merged commit 3ab0de6 into jef:main Jan 14, 2021
@wofnull wofnull deleted the computeruniverse_3060ti branch January 14, 2021 14:15
tylermilner added a commit to tylermilner/streetmerchant that referenced this pull request Jan 15, 2021
…-microcenter-out-of-stock

* 'main' of github.com:jef/streetmerchant: (23 commits)
  chore(deps-dev): bump webpack from 5.13.0 to 5.14.0 (jef#1692)
  chore(deps): bump puppeteer-extra from 3.1.15 to 3.1.16 (jef#1678)
  chore(deps): bump puppeteer-extra-plugin-block-resources from 2.2.7 to 2.2.8 (jef#1691)
  chore(deps): bump google-github-actions/release-please-action from v2.14 to v2.15 (jef#1655)
  chore(deps): bump @slack/web-api from 5.15.0 to 6.0.0 (jef#1669)
  fix(bandh): asus cards / out of stock check added (jef#1670)
  chore(deps): bump puppeteer-extra-plugin-stealth from 2.6.5 to 2.6.6 (jef#1680)
  chore(deps): bump twilio from 3.54.2 to 3.55.0 (jef#1679)
  chore(deps): bump puppeteer-extra-plugin-adblocker from 2.11.9 to 2.11.10 (jef#1681)
  chore(computeruniverse): add 3060ti cards (jef#1665)
  fix(wipoid): added 3090/3080/3070/3060ti/ryzen store items (jef#1683)
  feat(vsgamers): add maxPrice selector(jef#1682)
  fix(galaxus): update selector  ( 14.01.2020 07:00 ) (jef#1664)
  docs: add hyperlinks
  docs(twitch): add instructions on how to get tokens
  chore(lint): add void for dangling promise
  chore(deps): bump dependencies
  feat(twilio): add support to have multiple numbers (jef#1450)
  feat(galaxus): update selector, add out of stock check (jef#1607)
  feat(asus): add outOfStock label (jef#1653)
  ...
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot doesn't see 3060 ti at computeruniverse
2 participants