feat(store): addition of several australian sites #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing store to index.ts Added 1 Asus Card ( STRIX OC WHITE ) to Store.ts Added a handfull colorful cards / local variations for the AU market to Store.ts
jef
requested changes
Jan 14, 2021
jef
previously approved these changes
Jan 17, 2021
jef
approved these changes
Jan 17, 2021
|
Have no idea how you stumbled across my repo and apologies I am not comfortable enough with git yet to submit myself but great to see the store models / links going to use :) |
erwinc1
pushed a commit
to erwinc1/streetmerchant
that referenced
this pull request
Mar 31, 2021
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the repo of OptimalMising/streetmerchant , added several australian e-tailers to the streetmerchant script.:
Added aswell cards
Testing
Every single shop / item is crosstested and verified working as intended.
However: Harris Technology NEEDS! an Australia IP to work, a) via VPN (tested from my end) or b) via a proxy in australia. Outside of australia the site wont load and produces errors when loaded into streetmerchant:
[16:09:07] error :: ✖ [harristechnology] amd ryzen5600 5600x - net::ERR_CONNECTION_TIMED_OUT at https://www.ht.com.au/part/CA093-AMD-Ryzen-5-5600X-6-Core-3.7-GHz-Desktop-Processor-with-AM4-Socket-65W-Thermal-Design-Power/detail.hts