Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command parameter to set custom dotenv conf #1590

Merged
merged 3 commits into from
Jan 17, 2021

Conversation

pbaum83
Copy link
Contributor

@pbaum83 pbaum83 commented Jan 3, 2021

Allows users to define the dovenv config file at run time. The reason for doing this was to allow running multiple instances with different configurations or to just maintain more than one configuration without having to replace the configuration file.

Example:
npm --conf=myenvUS start
npm --conf=myenvCA start

image
image

Note: I am not a JS pro and not sure this is the best way to do this. Also, I wasn't able to figure out another way to do this, if this is already default functionality please close.

@pbaum83 pbaum83 requested a review from jef as a code owner January 3, 2021 19:31
@pbaum83 pbaum83 force-pushed the run-command-env-option branch from 5b86003 to 859734a Compare January 6, 2021 15:24
@pbaum83
Copy link
Contributor Author

pbaum83 commented Jan 6, 2021

Fixed the build errors and rebased branch on origin/main.

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Sorry it took awhile for me to pull it in.

🚀

@jef jef changed the title feat: Add command parameter to set custom dotenv conf feat: add command parameter to set custom dotenv conf Jan 17, 2021
@jef jef merged commit b03d242 into jef:main Jan 17, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants