fix: properly pass array entries as separate indices #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinc1
changed the title
|
Nice catch! You can fix the linting errors by running |
jef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The array of stores by default contains two shops in one entry. To fix this, you must enter both shops as separate entries.
Testing
old
[11:19:59 AM] warn :: No store named amazon,bestbuy, skipping.
[11:19:59 AM] info :: ℹ selected stores: amazon,bestbuy
[11:19:59 AM] info :: ℹ selected series: 3060ti, 3070, 3080, 3090, rx6800, rx6800xt, rx6900xt, ryzen5600, ryzen5800, ryzen5900, ryzen5950, sonyps5c, sonyps5de, xboxss, xboxsx
after fix
[11:25:15 AM] info :: ℹ selected stores: amazon, bestbuy
[11:25:15 AM] info :: ℹ selected series: 3060ti, 3070, 3080, 3090, rx6800, rx6800xt, rx6900xt, ryzen5600, ryzen5800, ryzen5900, ryzen5950, sonyps5c, sonyps5de, xboxss, xboxsx
[11:25:28 AM] info :: ✖ [amazon] [asus (3080)] strix :: OUT OF STOCK
[11:25:31 AM] info :: ✖ [amazon] [msi (3080)] gaming x trio :: OUT OF STOCK