Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord notifications incorrectly use dollar ($) sign by default #1318

Closed
YiIdirim opened this issue Dec 10, 2020 · 1 comment
Closed

Discord notifications incorrectly use dollar ($) sign by default #1318

YiIdirim opened this issue Dec 10, 2020 · 1 comment
Assignees
@jef
Labels
type: feature

Comments

@YiIdirim
Copy link
Contributor

YiIdirim commented Dec 10, 2020 •
edited
Loading

Expected Behavior

Notifications should show the price with the correct currency, e.g. £ for UK, $ for USA and € for EU countries.

Current Behavior

With the latest commits being pulled, notifications are showing Price with a dollar ($) sign preceding it. This is incorrect as I am searching UK stores and my currency is GBP (£). I believe this would also affect Euro (€) stores as well.

Steps to Reproduce

  1. Search for an in stock product. Make sure notifications are set correctly (e.g. Discord webhook).
  2. Notice that for a UK store, the price will show as $499.99.

PR opened that fixes this issue: #1328
@YiIdirim YiIdirim changed the title Discord/notifications incorrectly use dollar ($) sign by default Discord notifications incorrectly use dollar ($) sign by default Dec 10, 2020
@YiIdirim YiIdirim mentioned this issue Dec 10, 2020
Merged
@jef
Copy link
Owner

jef commented Dec 12, 2020

Resolved by #1328

@jef jef closed this as completed Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jef jef

Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jef @YiIdirim