Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop notifications need appID set in Windows 10 #1035

Closed
Hedova928 opened this issue Nov 30, 2020 · 3 comments
Closed

Desktop notifications need appID set in Windows 10 #1035

Hedova928 opened this issue Nov 30, 2020 · 3 comments

Comments

@Hedova928
Copy link

Hedova928 commented Nov 30, 2020

Description

Desktop notifications through node-notifier are not working in Windows 10. This seems to be due to the requirement to set an appID: https://www.npmjs.com/package/node-notifier#usage-windowstoaster

C:\Users\Hedova\Desktop\Programs\streetmerchant>npm run test:notification

> test:notification
> npm run build && node build/__test__/notification-test.js


> build
> tsc

STREETMERCHANT
3.1.0

INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
INFO: Could not find files for the given pattern(s).
[4:31:26 AM] info :: ✔ sound player found: cmdmp3
[4:31:27 AM] info :: ✔ desktop notification sent
Notifications are disabled
Reason: DisabledForUser Please make sure that the app id is set correctly.
Command Line: C:\Users\Hedova\Desktop\Programs\streetmerchant\node_modules\node-notifier\vendor\snoreToast\snoretoast-x64.exe -appID streetmerchant -pipeName \\.\pipe\notifierPipe-efc1ad6d-7071-4038-966f-ffe741f32252 -m https://www.example.com/cartUrl -t "[4:31:29 AM] info :: ✔ played sound
@jef
Copy link
Owner

jef commented Nov 30, 2020

Interesting... Thanks for the heads up

With the Fall Creators Update, Notifications on Windows 10 will only work as expected if a valid appID is specified. Your appID must be exactly the same value that was registered during the installation of your app.

In this case, I'm unsure what the appID would be. I don't know if we register it or not.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link
Contributor

This issue has been closed because it is stale. Reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants