Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more heuristics to item matching #100

Open
jedmund opened this issue Jun 8, 2020 · 0 comments
Open

Add more heuristics to item matching #100

jedmund opened this issue Jun 8, 2020 · 0 comments
Assignees
Labels
reliability Under the hood improvements

Comments

@jedmund
Copy link
Owner

jedmund commented Jun 8, 2020

$g until io grand lf -> works
$g until danua halloween halloween -> works
$g until dark cagliostro -> works
$g until summer zeta -> doesn't work

The current heuristics allow you to omit parentheses, proper capitalization, and flip elements, but you cannot flip suffixes like "Grand", "Summer", etc.

$g until danua halloween -> works

This doesn't do what a user expects, but it does do the logical thing. It treats halloween as the season and looks for Danua, of which there are two versions: her SR and her Light SSR.

In the fuzzy matching future, Danua's Halloween version will show up as an option as well, which is probably what the user intended.

@jedmund jedmund added the reliability Under the hood improvements label Jun 8, 2020
@jedmund jedmund self-assigned this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Under the hood improvements
Projects
None yet
Development

No branches or pull requests

1 participant