Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could their be any possible breaking changes? #135

Closed
Pauldic opened this issue Sep 16, 2020 · 2 comments
Closed

Could their be any possible breaking changes? #135

Pauldic opened this issue Sep 16, 2020 · 2 comments
Labels

Comments

@Pauldic
Copy link

Pauldic commented Sep 16, 2020

I got this while upgrading to Django 3.1.1
django-reversion-compare 0.12.2 requires django<3.1,>=2.2, but you'll have django 3.1.1 which is incompatible.

@jedie
Copy link
Owner

jedie commented Feb 4, 2021

We didn't restrict django version, see:

[tool.poetry.dependencies]
python = ">=3.7,<4.0.0"
django-reversion = "*"
diff-match-patch = "*"

And django-reversion doesn't so this, too. See:

https://github.com/etianen/django-reversion/blob/161dfeeac5b56a580e838eb0e35a9d17fe4fb024/setup.py#L37-L39

So i don't know where "django<3.1" comes from.
If you startup the test project, than Django 3.1.6 is currently used and it seems to work fine.

The tests runs against these Django versions:

django2.2: django~=2.2.0
django3.0: django~=3.0.0
django3.1: django~=3.1.0

So i have no idea what's happening in your setup.

@jedie jedie added the needhelp label Feb 4, 2021
@sjdemartini
Copy link

This appears to have been fixed with this PR #134 and released in v0.13.0

@jedie jedie closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants