Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1436
Moving to
settings.toml
was a regretful mistake. It turns out that having 2 config files in a CLI is just a bad idea. It's confusing to users and ultimately wasn't even necessary so we're going back to 1 file.Sorry for the musical chairs here. I know breaking changes like that are not great and especially when they get reverted it would be especially maddening. Moving back, however, should not be a breaking change.
We've taken steps to correct this from a project management perspective by setting up an advisory board: https://mise.jdx.dev/team.html You can certainly expect fewer abrupt changes in the future. A group of people able to review decisions like this before I roll out a change is exactly what this project needed.
We've gone through this together and came up with a plan to get us off of having
settings.toml
and back toconfig.toml
in a way that should involve minimal disruption—in fact I think it's possible nobody may even notice this change.This change should not negatively impact anyone. mise will read from both files and merge the contents, preferring
config.toml
. You can continue to usesettings.toml
and not change a thing. In a few weeks, I'm going to roll out another change to silently merge the contents ofsettings.toml
intoconfig.toml
. If you'd like to stay ahead of that, go ahead and put the contents ofsettings.toml
back intoconfig.toml
like before and nothing will change for you.I really am sorry for this one. I should've been a lot more careful rolling out the initial change to split these files up. Just know that we've definitely taken some steps to correct that.