Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle packageManager in package.json #2623

Open
viraptor opened this issue Sep 23, 2024 · 3 comments
Open

Handle packageManager in package.json #2623

viraptor opened this issue Sep 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@viraptor
Copy link

When using mise in a project with packageManager defined in package.json, I would expect that package to be installed/used in the same way .foo-version files are used.

But this:

{
  "name": "foo",
  "version": "1.2.3",
  "packageManager": "yarn@1.22.19"
}

and

mise x yarn -- yarn

ignores the configured version and runs (for example) v4.x.x

@viraptor viraptor added the enhancement New feature or request label Sep 23, 2024
@jdx
Copy link
Owner

jdx commented Sep 23, 2024

related: #1863

I think this could be done as a vfox/asdf/core plugin which just uses whatever node is on PATH. That wouldn't use corepack but I'm wondering if that ultimately matters to the user.

@viraptor
Copy link
Author

viraptor commented Sep 24, 2024

Isn't the node choice already done in the yarn plugin? I can mise x yarn@1.2.3 -- yarn install and it does the "right thing" in this case.

The only remaining issue seems to be not selecting the default version through the json file.

@jdx
Copy link
Owner

jdx commented Sep 24, 2024

that would be a feature request for asdf-yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants