Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the OAuth dialog #133

Open
jdgeenen opened this issue May 30, 2019 · 1 comment
Open

Improve the OAuth dialog #133

jdgeenen opened this issue May 30, 2019 · 1 comment
Assignees

Comments

@jdgeenen
Copy link
Owner

Is your feature request related to a problem? Please describe.
Improve the OAuth dialog.

Describe the solution you'd like
A cleaner dialog that displays the current URL so users have more confidence in how their credentials are handled.
Look into Thunderbird's OAuth dialog for Gmail.

Additional context
https://superuser.com/questions/1430046/how-can-i-know-for-sure-that-this-google-sign-in-is-legit/

@jdgeenen jdgeenen self-assigned this May 30, 2019
@jdgeenen
Copy link
Owner Author

jdgeenen commented May 31, 2019

mailnews/base/util/OAuth2.jsm appears to be what is used by TB.
It uses Services.ww.openWindow

requestWindowURI: "chrome://messenger/content/browserRequest.xul",
requestWindowFeatures: "chrome,private,centerscreen,width=980,height=750",

and a wrappedJSObject with several members (account, url, iconURI, cancelled, loaded, etc.) and the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant